-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobility Profile #1090
Mobility Profile #1090
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! As a next step, it is not clear the settings the user selected from the main settings page. It would be great that after parameters are defined that they are shown on the main page like this:
Define Your Mobility Profile
would be changed to Edit Your Mobility Profile
after the user has edited it >0 times
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really great! I do agree with Adriana's comment - ideally users should be able to see their selected settings without entering the wizard. Overall though, looks really good and just a couple of small questions
] | ||
|
||
const DeviceOption = styled.span` | ||
display: block; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we switched this to flex
and add a gap
? These labels and inputs are very close together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 23edbc8.
<Wizard | ||
activePaneId={activePaneId} | ||
formikProps={formikProps} | ||
pages={['mobility1', 'mobility2']} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change these to "assistive devices" and "limitations"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I did in b1ad318.
this._focusHeader() | ||
} else { | ||
// Display a toast to acknowledge saved changes | ||
// (although in reality, changes quietly took effect in previous screens). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, cool!
Good idea, I added a basic summary in a3a0a85. |
Updated in d680855 |
Description
Works with ibi-group/otp-middleware#200.
This PR includes changes for enabling in config the mobility profile pages in the settings pages,
whether it is on creating new accounts or existing accounts.
To enable mobility profiles, simply add a line in config.yml with:
Behind the scenes, the code for
UserAccountScreen
is heavily modified, and the "wizard" concept (previouslySequentialPaneDisplay
) is used more widely for the mobility profile setup screen.PR Checklist: