Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stricter cases to enable pattern filtering #1087

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Stricter cases to enable pattern filtering #1087

merged 3 commits into from
Dec 8, 2023

Conversation

miles-grant-ibigroup
Copy link
Collaborator

Description:

If only one pattern is returned, it's possible the pattern filtering is filtering too many patterns!

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

amy-corson-ibigroup
amy-corson-ibigroup approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the comment since this no longer just applies to if the filter removes all patterns?

AdrianaCeric
AdrianaCeric approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@AdrianaCeric AdrianaCeric left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 . see Amy's comment

@miles-grant-ibigroup miles-grant-ibigroup merged commit 1a0bbf5 into dev Dec 8, 2023
9 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the more-pattern-filtering-improvements branch December 8, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amy-corson-ibigroup amy-corson-ibigroup amy-corson-ibigroup approved these changes

@AdrianaCeric AdrianaCeric AdrianaCeric approved these changes

Assignees

@miles-grant-ibigroup miles-grant-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miles-grant-ibigroup @AdrianaCeric @amy-corson-ibigroup