Prevent mobile view change on location clear #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-heppner-ibigroup
requested changes
Dec 4, 2023
daniel-heppner-ibigroup
assigned amy-corson-ibigroup and unassigned daniel-heppner-ibigroup
daniel-heppner-ibigroup
approved these changes
Dec 11, 2023
daniel-heppner-ibigroup
assigned amy-corson-ibigroup and unassigned daniel-heppner-ibigroup
|
@amy-corson-ibigroup Do we need to fix some of the Percy tests? |
|
@binh-dam-ibigroup Fixed! |
|
As @binh-dam-ibigroup pointed out, the mobile nav bar already has a back arrow, so I've used that instead of creating my own! I've also updated the back arrow to be web accessible but changing it from a |
binh-dam-ibigroup
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
As @binh-dam-ibigroup pointed out, the mobile nav bar already has a back arrow, so I've used that instead of creating my own! I've also updated the back arrow to be web accessible but changing it from a
divto abuttonand adding anaria-label
Nice fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently when you clear a location field in mobile view, it resets the view back to the form. This PR changes that so now using the clear location button just clears the location.
This PR also updates the mobile bar back button to be web accessible, and turns it on for the location field.
PR Checklist: