-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add GeoJSONOverlay #1082
Merged
Merged
add GeoJSONOverlay #1082
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
819e5d2
add GeoJSONOverlay
miles-grant-ibigroup c7669a4
Merge branch 'dev' into geojson-layer
miles-grant-ibigroup 2e5b207
address pr feedback
miles-grant-ibigroup b3462fd
address pr feedback
miles-grant-ibigroup 95ed15f
Merge branch 'dev' into geojson-layer
miles-grant-ibigroup File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,79 @@ | ||
import { | ||
Styled as BaseMapStyled, | ||
MarkerWithPopup | ||
} from '@opentripplanner/base-map' | ||
import { connect } from 'react-redux' | ||
import FromToLocationPicker from '@opentripplanner/from-to-location-picker' | ||
import React, { useEffect, useState } from 'react' | ||
|
||
import { setLocation } from '../../actions/map' | ||
|
||
const GeoJSONOverlay = (props) => { | ||
const { setLocation, url } = props | ||
Check failure on line 12 in lib/components/map/connected-geojson-layer.js GitHub Actions / test-build-release
|
||
|
||
const [locations, setLocations] = useState([]) | ||
useEffect(() => { | ||
async function downloadLocations() { | ||
const json = await (await fetch(url)).json() | ||
setLocations(json) | ||
} | ||
if (url) downloadLocations() | ||
}, []) | ||
|
||
return ( | ||
<> | ||
{locations?.features?.map((feature, k) => { | ||
const { geometry, properties } = feature | ||
if (!geometry || !geometry.coordinates) return null | ||
return ( | ||
<MarkerWithPopup | ||
key={k} | ||
popupContents={ | ||
<BaseMapStyled.MapOverlayPopup> | ||
{properties.Name && ( | ||
<BaseMapStyled.PopupTitle> | ||
{properties.Name} | ||
</BaseMapStyled.PopupTitle> | ||
)} | ||
<BaseMapStyled.PopupRow> | ||
{properties.popupContent && ( | ||
<div>{properties.popupContent}</div> | ||
)} | ||
{properties.Address && ( | ||
<div> | ||
{properties.Address}, {properties.Zip}, {properties.City},{' '} | ||
{properties.State} | ||
</div> | ||
)} | ||
{properties.Phone && <div>{properties.Phone}</div>} | ||
<FromToLocationPicker | ||
label | ||
location={{ | ||
lat: geometry.coordinates[1], | ||
lon: geometry.coordinates[0], | ||
name: properties.Name | ||
}} | ||
setLocation={setLocation} | ||
/> | ||
</BaseMapStyled.PopupRow> | ||
</BaseMapStyled.MapOverlayPopup> | ||
} | ||
popupProps={{ offset: 10 }} | ||
position={[geometry.coordinates[1], geometry.coordinates[0]]} | ||
> | ||
<img | ||
alt={properties.Name} | ||
src={properties.icon} | ||
style={{ height: 40 }} | ||
/> | ||
</MarkerWithPopup> | ||
) | ||
})} | ||
</> | ||
) | ||
} | ||
const mapDispatchToProps = { | ||
setLocation | ||
} | ||
|
||
export default connect(null, mapDispatchToProps)(GeoJSONOverlay) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is coming across as very tall!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree let's remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a
className
should still be set on the<img>
tag so that the configs can style the images if needed.