Support larger custom route renderers #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-heppner-ibigroup
approved these changes
Nov 30, 2023
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
binh-dam-ibigroup
requested changes
Dec 4, 2023
| @@ -700,10 +700,6 @@ export const findRoute = (params) => | |||
| newRoute.patterns = routePatterns | |||
| // TODO: avoid explicit behavior shift like this | |||
| newRoute.v2 = true | |||
| newRoute.color = getRouteColorBasedOnSettings( | |||
There was a problem hiding this comment.
We should keep this as fallback if a route color is not provided in OTP, and for cases where we want to override route colors in config, I think.
There was a problem hiding this comment.
The reason it is removed here is that we instead do the override in every location where the color is used. This gives us more flexibility in how we use the color. Try it! a feed with no color still gets overriden
binh-dam-ibigroup
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adjusts color handling to be more consistent and allow for more situations.
LOOKING FOR FEEDBACK:
PR Checklist: