Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(i18n): Correctly load OTP-UI's Chinese (simplified) files. #1040

Merged
merged 2 commits into from
Oct 18, 2023
Merged

fix(i18n): Correctly load OTP-UI's Chinese (simplified) files. #1040

merged 2 commits into from
Oct 18, 2023

Conversation

binh-dam-ibigroup
Copy link
Collaborator

Description

This PR ensures that the OTP-UI's language files for Chinese (Simplified) are correctly loaded.

PR Checklist

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

AdrianaCeric
AdrianaCeric approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@AdrianaCeric AdrianaCeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

@binh-dam-ibigroup binh-dam-ibigroup merged commit b2dedb4 into dev Oct 18, 2023
7 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the load-simplified-chinese branch October 18, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amy-corson-ibigroup amy-corson-ibigroup amy-corson-ibigroup approved these changes

@AdrianaCeric AdrianaCeric AdrianaCeric approved these changes

Assignees

@binh-dam-ibigroup binh-dam-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binh-dam-ibigroup @AdrianaCeric @amy-corson-ibigroup