Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use brand colors in date-time-picker #1032

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Use brand colors in date-time-picker #1032

merged 4 commits into from
Oct 17, 2023

Conversation

miles-grant-ibigroup
Copy link
Collaborator

Description:

Small change to remove the basic whites and weird blues and instead use the brand colors!

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

amy-corson-ibigroup
amy-corson-ibigroup approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Wondering how both you and second reviewer would feel about slightly higher font weight on the button text? It's a little hard to read the white text as is right now.

@miles-grant-ibigroup
Copy link
Collaborator Author

I wouldn't mind. Second reviewer what do you think

@binh-dam-ibigroup
Copy link
Collaborator

I wouldn't mind. Second reviewer what do you think

I wouldn't mind, however this may exacerbate overflowing text in some cases, such as in this screenshot:
image

binh-dam-ibigroup
binh-dam-ibigroup approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I would vote in favor of bolding the drop down button text.

@miles-grant-ibigroup
Copy link
Collaborator Author

Let's table the bolding for now and do that in a separate PR

@miles-grant-ibigroup miles-grant-ibigroup merged commit 748ed32 into dev Oct 17, 2023
7 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the use-brand-color-in-date-time-picker branch October 17, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amy-corson-ibigroup amy-corson-ibigroup amy-corson-ibigroup approved these changes

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

Assignees

@miles-grant-ibigroup miles-grant-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miles-grant-ibigroup @binh-dam-ibigroup @amy-corson-ibigroup