Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(user-account-screen): Pass the correct object for persisting. #1026

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix(user-account-screen): Pass the correct object for persisting. #1026

merged 1 commit into from
Oct 9, 2023

Conversation

binh-dam-ibigroup
Copy link
Collaborator

Description

This PR fixes an incorrect call ot OTP-middleware that prevents creating a new user.

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

amy-corson-ibigroup
amy-corson-ibigroup approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works! Thanks for the quick fix!

miles-grant-ibigroup
miles-grant-ibigroup approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@miles-grant-ibigroup miles-grant-ibigroup merged commit f27e945 into dev Oct 9, 2023
7 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the fix-saving-notification-channel branch October 9, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amy-corson-ibigroup amy-corson-ibigroup amy-corson-ibigroup approved these changes

@miles-grant-ibigroup miles-grant-ibigroup miles-grant-ibigroup approved these changes

Assignees

@miles-grant-ibigroup miles-grant-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binh-dam-ibigroup @miles-grant-ibigroup @amy-corson-ibigroup