fix(AppMenuItem): Make app menu external links open in new browser tab. #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-corson-ibigroup
approved these changes
Oct 5, 2023
| @@ -68,7 +68,9 @@ export default class AppMenuItem extends Component<Props, State> { | |||
| render(): JSX.Element { | |||
| const { icon, id, onClick, subItems, text, ...otherProps } = this.props | |||
| const { isExpanded } = this.state | |||
| const Element = otherProps.href ? 'a' : 'button' | |||
| const hasHref = !!otherProps.href | |||
| const isAbsolute = otherProps.href?.startsWith('http') | |||
There was a problem hiding this comment.
If a url gets passed without an http should it still open a new browser tab?
There was a problem hiding this comment.
Then it would be a relative URL (like the route viewer or another resource), but that's a good question.
There was a problem hiding this comment.
Right now, relative URLs open in the same window per PR description.
AdrianaCeric
approved these changes
Oct 6, 2023
| @@ -68,7 +68,9 @@ export default class AppMenuItem extends Component<Props, State> { | |||
| render(): JSX.Element { | |||
| const { icon, id, onClick, subItems, text, ...otherProps } = this.props | |||
| const { isExpanded } = this.state | |||
| const Element = otherProps.href ? 'a' : 'button' | |||
| const hasHref = !!otherProps.href | |||
| const isAbsolute = otherProps.href?.startsWith('http') | |||
There was a problem hiding this comment.
Looks good! One suggestion, but not needed:
Suggested change
| const isAbsolute = otherProps.href?.startsWith('http') | |
| const isAbsolute = hasHref && otherProps.href?.startsWith('http') |
There was a problem hiding this comment.
It is not needed. That condition would be redundant, as otherProps.href?.startsWith(...) is null if otherProps.href is null, and can't be non-null unless otherProps.hrefis non null. Same for your other suggestion.
| @@ -80,6 +82,7 @@ export default class AppMenuItem extends Component<Props, State> { | |||
| onClick={subItems ? this._toggleSubmenu : onClick} | |||
| onKeyDown={this._handleKeyDown} | |||
| {...otherProps} | |||
| target={hasHref && isAbsolute ? '_blank' : undefined} | |||
There was a problem hiding this comment.
Suggested change
| target={hasHref && isAbsolute ? '_blank' : undefined} | |
| target={isAbsolute ? '_blank' : undefined} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes external links in the app menu open in a new browser tab.
There are no changes to external link configurations.
(Relative links would still open in the same window.)
PR Checklist: