Add configuration types. #1017
Add configuration types. #1017
Conversation
| @@ -89,7 +90,7 @@ class AppMenu extends Component< | |||
|
|
|||
| _triggerPopup = () => { | |||
| const { popupTarget, setPopupContent } = this.props | |||
| setPopupContent(popupTarget) | |||
| if (popupTarget) setPopupContent(popupTarget) | |||
There was a problem hiding this comment.
popupTarget is optional, so TypeScript forces this truthy check before triggering the popup.
| const modeColors: ModeColors = {} | ||
| transitModes.forEach((mode: ConfiguredTransitMode) => { | ||
| state.otp.config.modes.transitModes.forEach((mode) => { |
There was a problem hiding this comment.
Do you want to also add the
const { config: otpConfig } = state.otp here?
There was a problem hiding this comment.
Not needed, in this file, it is used only on this line.
| @@ -95,10 +95,3 @@ export type SetViewedRouteHandler = (route?: ViewedRouteState) => void | |||
| export type SetViewedStopHandler = (payload: { stopId: string } | null) => void | |||
|
|
|||
| export type SetLocationHandler = (payload: MapLocationActionArg) => void | |||
|
|
|||
| export interface ConfiguredTransitMode { | |||
There was a problem hiding this comment.
Why is this interface being removed?
There was a problem hiding this comment.
I moved it to config-types.ts, and it is now called TransitModeConfig.
| # Allows calorie counts to be hidden | ||
| displayCalories: true |
There was a problem hiding this comment.
Was this behavior removed?
There was a problem hiding this comment.
Displaying calories was completely removed from OTP-UI, so this doesn't apply anymore.
| displayCalories: | ||
| typeof itinerary?.displayCalories === 'boolean' |
There was a problem hiding this comment.
Why was this removed?
There was a problem hiding this comment.
Displaying calories was completely removed from OTP-UI, so this doesn't apply anymore.
Description
This PR introduces types used in the app configuration (config.yml), and a partial redux state type is added.
The new types are not necessarily exhaustive and may not include obsolete config properties still in example-config.yml.
A few component files have been changed just to give an idea of the direction taken.
Note that calltaker config types are still to be implemented.
PR Checklist