Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove calltaker index imports #1011

Merged
merged 9 commits into from
Oct 19, 2023
Merged

Conversation

binh-dam-ibigroup
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup commented Sep 22, 2023

Description:

This PR unbundles calltaker from non-calltaker instances.

For calltaker configs, import calltaker components as follows (as needed):

import CallTakerControls from '../lib/components/admin/call-taker-controls'
import CallHistoryWindow from '../lib/components/admin/call-history-window'
import CallTakerPanel from '../lib/components/app/call-taker-panel'
import FieldTripWindows from '../lib/components/admin/field-trip-windows'
import MailablesWindow from '../lib/components/admin/mailables-window'

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing an error when trying to run a call-taker config. Is there something I have to change in the config?

Screenshot 2023-09-26 at 2 51 37 PM

@binh-dam-ibigroup
Copy link
Collaborator Author

I'm seeing an error when trying to run a call-taker config. Is there something I have to change in the config?

Yes, instead of importing from ../lib, import the component from the module that defines it.

Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great, thanks so much for the changes

Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! Do you think we could add some documentation to explain how to enable the call taker module? Perhaps we need some better docs on config.js in general

@binh-dam-ibigroup binh-dam-ibigroup merged commit 9a8f7f1 into dev Oct 19, 2023
7 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the remove-calltaker-index-imports branch October 19, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants