Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(date-time-button): Allow click interaction on mobile view. #1003

Merged
merged 3 commits into from
Sep 22, 2023
Merged

fix(date-time-button): Allow click interaction on mobile view. #1003

merged 3 commits into from
Sep 22, 2023

Conversation

binh-dam-ibigroup
Copy link
Collaborator

Description

This PR fixes the non-clickability of the date/time preview button in the main form when using the mobile view.

PR Checklist

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • [na] Are all languages supported (Internationalization/Localization)?
  • [na] Are appropriate Typescript types implemented?

amy-corson-ibigroup
amy-corson-ibigroup approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

AdrianaCeric
AdrianaCeric approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@AdrianaCeric AdrianaCeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@binh-dam-ibigroup binh-dam-ibigroup merged commit 11e5570 into dev Sep 22, 2023
6 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the fix-date-time-selector-mobile branch September 22, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amy-corson-ibigroup amy-corson-ibigroup amy-corson-ibigroup approved these changes

@AdrianaCeric AdrianaCeric AdrianaCeric approved these changes

Assignees

@binh-dam-ibigroup binh-dam-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binh-dam-ibigroup @AdrianaCeric @amy-corson-ibigroup