Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nearby stop popups #1001

Merged
merged 12 commits into from
Sep 25, 2023
Merged

Fix nearby stop popups #1001

merged 12 commits into from
Sep 25, 2023

Conversation

binh-dam-ibigroup
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup commented Sep 19, 2023

Description

This PR fixes an issue where two stop info popups can be shown for the same stop when clicking the nearby stops on the map, and unifies styling of the stop popups.

PR Checklist

  • [na] Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these improvements, hopefully we can eliminate the duplicated popup in the future...

Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for the updates!

@amy-corson-ibigroup amy-corson-ibigroup removed their assignment Sep 25, 2023
@binh-dam-ibigroup binh-dam-ibigroup merged commit cfec6bb into dev Sep 25, 2023
6 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the fix-nearby-stop-popups branch September 25, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants