complete pr feedback addressing

opentripplanner · Oct 7, 2024 · 999c8a9 · 999c8a9
1 parent b457c6f
commit 999c8a9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/lib/actions/apiV2.js b/lib/actions/apiV2.js
@@ -832,12 +832,10 @@ export function findRoutes() {
 
     dispatch(
       createGraphQLQueryAction(
-        `{
-          routes ${
-            currentServiceWeek
-              ? `(serviceDates: {start: "${currentServiceWeek.start}", end: "${currentServiceWeek.end}"})`
-              : ''
-          }{
+        `query Routes(
+          $currentServiceWeek: LocalDateRangeInput
+         ) {
+          routes (serviceDates: $currentServiceWeek) {
             id: gtfsId
             agency {
               id: gtfsId
@@ -852,7 +850,7 @@ export function findRoutes() {
           }
         }
       `,
-        {},
+        { currentServiceWeek },
         findRoutesResponse,
         findRoutesError,
         {

diff --git a/lib/components/viewers/nearby/stop.tsx b/lib/components/viewers/nearby/stop.tsx
@@ -70,6 +70,8 @@ const Stop = ({
         (a: StopTime, b: StopTime) => fullTimestamp(a) - fullTimestamp(b)
       )
       if (
+        // NearbyRoutes if present is populated with a list of routes that appear
+        // in the current service period.
         stopData.nearbyRoutes &&
         !stopData.nearbyRoutes.includes(st?.pattern?.route?.gtfsId)
       ) {