refactor: Remove unused max[Walk/Bike]Distance URL param

opentripplanner · May 31, 2024 · 0c697e1 · 0c697e1
1 parent dd84489
commit 0c697e1
Show file tree

Hide file tree

Showing 7 changed files with 5 additions and 10 deletions.
diff --git a/__tests__/reducers/__snapshots__/create-otp-reducer.js.snap b/__tests__/reducers/__snapshots__/create-otp-reducer.js.snap
@@ -29,10 +29,8 @@ Object {
     "endTime": "09:00",
     "from": null,
     "intermediatePlaces": Array [],
-    "maxBikeDistance": 4828,
     "maxBikeTime": 20,
     "maxEScooterDistance": 4828,
-    "maxWalkDistance": 1609,
     "maxWalkTime": 15,
     "mode": "WALK,TRANSIT",
     "numItineraries": 3,

diff --git a/__tests__/reducers/__snapshots__/create-user-reducer.js.snap b/__tests__/reducers/__snapshots__/create-user-reducer.js.snap
@@ -14,10 +14,8 @@ Object {
       "bikeSpeed": 3.58,
       "endTime": "09:00",
       "intermediatePlaces": Array [],
-      "maxBikeDistance": 4828,
       "maxBikeTime": 20,
       "maxEScooterDistance": 4828,
-      "maxWalkDistance": 1609,
       "maxWalkTime": 15,
       "mode": "WALK,TRANSIT",
       "numItineraries": 3,

diff --git a/a11y/a11y.test.js b/a11y/a11y.test.js
@@ -94,7 +94,7 @@ routes.forEach((route) => {
 
 test('Mocked Main Trip planner page should pass Axe Tests', async () => {
   await runAxeTestOnPath(
-    '/?ui_activeSearch=0qoydlnut&ui_activeItinerary=0&fromPlace=1900%20Main%20Street%2C%20Houston%2C%20TX%2C%20USA%3A%3A29.750144%2C-95.370998&toPlace=800%20Congress%2C%20Houston%2C%20TX%2C%20USA%3A%3A29.76263%2C-95.362178&date=2021-08-04&time=08%3A14&arriveBy=false&mode=WALK%2CBUS%2CTRAM&maxWalkDistance=1207&walkSpeed=1.34&numItineraries=3'
+    '/?ui_activeSearch=0qoydlnut&ui_activeItinerary=0&fromPlace=1900%20Main%20Street%2C%20Houston%2C%20TX%2C%20USA%3A%3A29.750144%2C-95.370998&toPlace=800%20Congress%2C%20Houston%2C%20TX%2C%20USA%3A%3A29.76263%2C-95.362178&date=2021-08-04&time=08%3A14&arriveBy=false&mode=WALK%2CBUS%2CTRAM&walkSpeed=1.34&numItineraries=3'
   )
 })
 

diff --git a/a11y/mocks/plan.json b/a11y/mocks/plan.json
diff --git a/example-config.yml b/example-config.yml
@@ -57,7 +57,7 @@ api:
 ### The default query parameters can be overridden be uncommenting this object.
 ### Note: the override values must be valid values within otp-ui's query-params.js
 # defaultQueryParams:
-#   maxWalkDistance: 3219 # 2 miles in meters
+#   walkSpeed: 1.34 # 3 mph in meters per second
 
 ### The persistence setting is used to enable the storage of places (home, work),
 ### recent searches/places, user overrides, and favorite stops.

diff --git a/lib/util/api.ts b/lib/util/api.ts
@@ -68,4 +68,6 @@ export function removeUnusedQueryParams(params: any): void {
   delete params.ignoreRealtimeUpdates
   delete params.optimize
   delete params.optimizeBike
+  delete params.maxWalkDistance
+  delete params.maxBikeDistance
 }
diff --git a/percy/har-mock-config.yml b/percy/har-mock-config.yml
@@ -118,6 +118,3 @@ accessibilityScore:
     1.0:
       color: "#a2e099"
       icon: thumbs-up
-
-defaultQueryParams:
-  maxWalkDistance: 1207 # 3/4 miles in meters