Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in getTemporaryIds() #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

darrenfoong
Copy link

There is no need to multiply System.currentTimeMillis() by 1000 as it is already in milliseconds.

Also, it is better to use Instant, instead of performing accident-prone conversions (which appear often in the current code).

Copy link

@achraf52 achraf52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified that, as the name implies, calling System.currentTimeMillis(); returns the current timestamp in milliseconds, thus multiplication by 1000 will lead to erroneous values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants