DEVX-8994: Change default client tokens to JWT #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning Do not merge/deploy until @dragonmantank has confirmed this can go out. |
superchilled
commented
Nov 13, 2024
lib/opentok/session.rb
Outdated
| @@ -28,6 +28,7 @@ module OpenTok | |||
| # Generates a token. | |||
| # | |||
| # @param [Hash] options | |||
| # @option options [String] :token_type The type of token to generate. Must be one of 'T1' or 'JWT'. | |||
There was a problem hiding this comment.
@jeffswartz I think we'll need to update the OT docs here and here to cover this new param.
superchilled
commented
Nov 13, 2024
lib/opentok/opentok.rb
Outdated
| @@ -36,6 +36,7 @@ module OpenTok | |||
| # the token. | |||
| # | |||
| # @param [Hash] options A hash defining options for the token. | |||
| # @option options [String] :token_type The type of token to generate. Must be one of 'T1' or 'JWT'. | |||
There was a problem hiding this comment.
@jeffswartz I think we'll need to update the OT docs here and here to cover this new param.
dragonmantank
approved these changes
Dec 11, 2024
superchilled
deleted the
devx-8994-change-default-client-tokens-to-jwt
branch
superchilled
restored the
devx-8994-change-default-client-tokens-to-jwt
branch
superchilled
added a commit
that referenced
this pull request
Dec 13, 2024
This reverts commit 73f4828.
superchilled
added a commit
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to create JWT client tokens and sets this as the default, with the option to create T1 tokens if the user specifies this. Specifically the PR:
token_typeparam in thegenerate_tokenmethod:token_typeparam is ommitted, a JWT is generated