search result highlight #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubabrzy
force-pushed
the
search-result-highlight
branch
from
62e2432 to
fb2bbc8
Compare
Roma36
approved these changes
Sep 18, 2023
|
@damianstasik btw, why is the dark mode primary brand color brighter than light mode one? Maybe we should change it? |
|
@Roma36 there might be a few things that use this CSS variable. We may try to look through all pages and see if that's still used anywhere, if not then let's remove it completely. Last place I think used it was the documentation sidebar, now everything it explicit there. |
Roma36
approved these changes
Sep 19, 2023
damianstasik
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes color for highlighted item for search in dark mode
closes #113