Common options / parseCommon fix #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvaccaro
reviewed
Aug 22, 2019
| @@ -126,6 +129,7 @@ const upgradeCommand = program | |||
| } | |||
| options = parseCommon(options) | |||
| options.calendars = options.calendar | |||
| options = parseCommon(options) | |||
There was a problem hiding this comment.
nit: I think this is not needed
There was a problem hiding this comment.
Indeed not needed, too much copy-paste :)
|
re 98fbd12 : The whitelist stuff is not needed for |
|
I'd like to add |
|
Cool! It's there. All good, thanks for the review @lvaccaro. |
|
ack 3eb2f4d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "common" options
verbose,whitelistandno-default-whitelistwere ignored. I changed the commander stuff so they are now taken into account.Will probably solve issue #42 also.