Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: for lava tiles in entrance of The Pits of Inferno Quest #3196

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

jeansouzak
Copy link
Contributor

Description

This pull request implements an alternative solution to handle lava tiles in The Pits of Inferno Quest. The logic in register_actions.lua has been modified to transform existing lava items (ID: 21477) into the floor item (ID: 5815) using Tile:getItemById and Item:transform, instead of relying on Game.createItem.
This PR addresses an issue where lava tiles in The Pits of Inferno Quest were not behaving as expected 3144.

Behaviour

Actual

When using the pick on the stone, the floor is created but it does not let you pass, you just bounce and it tells you "there is not enough room"

Expected

By using the pickaxe on the stone, the floor is created and you can pass through and continue the mission.

Fixes #3144

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Go to The Pits of Inferno lever.
  • Use oil on the lever.
  • Use the lever.
  • Use a pick on the corner stone.
  • Pass through the lava to continue your mission.
  • Verify that the lava tiles (ID: 21477) are properly transformed into floor items (ID: 5815) during this process.

Test Configuration:

  • Server Version: 13.40
  • Client: mehah otclient
  • Operating Server (docker ubuntu), Client (Windows):

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Implemented an alternative solution to handle lava tiles in The Pits of Inferno Quest. Modified the logic in register_actions.lua to transform existing lava items (ID: 21477) into the floor item (ID: 5815) instead of use Game.createItem.
@jeansouzak jeansouzak changed the title Fix for lava tiles in entrance of The Pits of Inferno Quest fix: for lava tiles in entrance of The Pits of Inferno Quest Dec 26, 2024
@helenarubra
Copy link

I believe there is another condition that causes the same problem, I'm not sure but I will test it tonight and report it here.

@dudantas dudantas merged commit f81e5cd into opentibiabr:main Dec 27, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

floor in entrance of poi is not allowed to walk on it
4 participants