-
-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check creatures crash #3168
Conversation
There can be no concurrency in checkCreatureLists, it is modified in the same thread, if there really was concurrency between threads, which I believe is not the case, we need to find a solution and fix it, mutex in my opinion is not the best solution, it should be avoided as much as possible. and about the tests, I usually test with 150x150 = 22,500 creatures and there were no crashes. about my fix, did you test it and were there any crashes? |
Yep using your code debug break in middle of code. |
Quality Gate passedIssues Measures |
OK, could you test again, because I believe the problem is the updateIddle inside onThink that is executed inside checkCreatures, it is putting a creature in the list while it is inside the loop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
work fine
No description provided.