fix: check creatures crash

[mehah]

No description provided.

[W4gNII]

i fix using mutex, i got a god result ..

[mehah]

@W4gNII

There can be no concurrency in checkCreatureLists, it is modified in the same thread, if there really was concurrency between threads, which I believe is not the case, we need to find a solution and fix it, mutex in my opinion is not the best solution, it should be avoided as much as possible.

and about the tests, I usually test with 150x150 = 22,500 creatures and there were no crashes.

about my fix, did you test it and were there any crashes?

[W4gNII]

Yep using your code debug break in middle of code.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[mehah]

@W4gNII

OK, could you test again, because I believe the problem is the updateIddle inside onThink that is executed inside checkCreatures, it is putting a creature in the list while it is inside the loop.

[W4gNII]

work fine