Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: packet interpretation parseSetOutfit for otcv8/old protocol #3162

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

kokekanon
Copy link
Contributor

@kokekanon kokekanon commented Nov 29, 2024

Description

this problem is since August when version was upgraded to 13.40 but no v8 user reported it, until issues: 3155

1) canary expects a packet “isMountRandomized” u16 but is only sent by cipsoft 13.34 and OTCR 13.34

v8 old Protocol no send "isMountRandomized" , last packet is newOutfit.lookMount = msg.get<uint16_t>(); canary read in (L1711)

this is from v8:
image
https://github.com/opentibiabr/otcv8/blob/main/src/client/protocolgamesend.cpp#L833

(Redemption 11.00 no send isMountRandomized only in 13.34)

2) load this (sendCreatureOutfit and AddCreature) into AddOutfit

(same packets)
image

Behaviour

Actual

[2024-29-11 14:25:47.050] [error] [NetworkMessage::getByte] Not enough data to read a byte. Current position: 26, Length: 18. Called line 1692:50 in void __cdecl ProtocolGame::parseSetOutfit(class NetworkMessage &)

Expected

Do this and that happens

Fixes

#3155

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

image

Test Configuration:

  • Server Version: 11.00 / 13.40
  • Client: otcr / v8 / cip´soft
  • Operating System: win 11

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@murilo09 murilo09 changed the title fix: packet interpretation parseSetOutfit V8-OldProtocol (issues: #3155 ) fix: packet interpretation parseSetOutfit V8-OldProtocol Dec 5, 2024
Copy link

sonarqubecloud bot commented Dec 6, 2024

@dudantas dudantas changed the title fix: packet interpretation parseSetOutfit V8-OldProtocol fix: packet interpretation parseSetOutfit for otcv8/old protocol Dec 9, 2024
@dudantas dudantas merged commit 8891f3a into opentibiabr:main Dec 9, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants