Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: wheel #3157

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

perf: wheel #3157

wants to merge 7 commits into from

Conversation

phacUFPE
Copy link
Contributor

@phacUFPE phacUFPE commented Nov 27, 2024

Description

Fixes performance issues in the wheel ui, also add the disable of the apply button when the changes be applied and some functions calling order.

Behaviour

Actual

Apply button does not disable after changes applied.

Expected

Apply button does disable after changes applied.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Change the wheel points or gem and apply the changes.

Test Configuration:

  • Server Version: Latest
  • Client: 13.40
  • Operating System: Windows 11

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@dudantas dudantas linked an issue Nov 28, 2024 that may be closed by this pull request
5 tasks
@odisk777
Copy link
Contributor

odisk777 commented Dec 1, 2024

I don't know if this is the solution but some users report high ping when they are using the wheels

@luiscaldera
Copy link

I don't know if this is the solution but some users report high ping when they are using the wheels

I just tried these changes and it doesn't solve the problem of increasing the ping on the server when making a change in the wheel and pressing either "reset" "apply" or "ok"
I can also upload a video showing how the server gets this error

@phacUFPE
Copy link
Contributor Author

phacUFPE commented Dec 1, 2024

I don't know if this is the solution but some users report high ping when they are using the wheels

I just tried these changes and it doesn't solve the problem of increasing the ping on the server when making a change in the wheel and pressing either "reset" "apply" or "ok" I can also upload a video showing how the server gets this error

Please, upload a video to see how it happens.

@luiscaldera
Copy link

I don't know if this is the solution but some users report high ping when they are using the wheels

I just tried these changes and it doesn't solve the problem of increasing the ping on the server when making a change in the wheel and pressing either "reset" "apply" or "ok" I can also upload a video showing how the server gets this error

Please, upload a video to see how it happens.

https://imgur.com/a/g8IvXaQ

There you can see that it is very few seconds that it is stuck, I am with the current data of otservbr, using a windows vps it was much more noticeable and I changed to a linux with 6 vCPU Cores
16 GB RAM and it is hardly noticeable as now in the video

@odisk777
Copy link
Contributor

odisk777 commented Dec 3, 2024

here I am testing I have a nomal ms
Uploading client 2024-12-03 16-34-52-851 (online-video-cutter.com).mp4…

@odisk777
Copy link
Contributor

odisk777 commented Dec 3, 2024

client.2024-12-03.16-34-52-851.online-video-cutter.com.mp4

@luiscaldera
Copy link

client.2024-12-03.16-34-52-851.online-video-cutter.com.mp4

https://imgur.com/a/i5sLUT5

I just recorded showing the performance of the VPS while applying points on the wheel

@odisk777
Copy link
Contributor

odisk777 commented Dec 3, 2024

I just recorded showing the performance of the VPS while applying points on the wheel

I think you are right I'm just using the wheels and start to raise the cores I know I have only 2 cores but I only have the canary and mysql installed and I know that will hurt the performance canary but as a normal test server, now I imagine several users doing the same thing at the same time will raise all the cores so you have 8 or 14 cores will still go up and you will lose server performance would be an objective of the users to knock down the server.

bandicam.2024-12-03.18-00-45-378.mp4

@dudantas dudantas marked this pull request as draft December 5, 2024 02:59
@phacUFPE phacUFPE changed the title fix: wheel ui perf: wheel Dec 13, 2024
@phacUFPE
Copy link
Contributor Author

client.2024-12-03.16-34-52-851.online-video-cutter.com.mp4

https://imgur.com/a/i5sLUT5

I just recorded showing the performance of the VPS while applying points on the wheel

I pushed new code with some performance updates, could you please test?

@phacUFPE phacUFPE force-pushed the phacUFPE/fix_ui_wheel branch from cf77e71 to ca1a429 Compare December 15, 2024 02:56
@phacUFPE phacUFPE marked this pull request as ready for review December 15, 2024 02:56
@phacUFPE phacUFPE force-pushed the phacUFPE/fix_ui_wheel branch from 6bed6a0 to 6e62854 Compare December 16, 2024 03:23
Copy link

sonarcloud bot commented Dec 16, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wheel of Destiny
4 participants