-
-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: wheel #3157
base: main
Are you sure you want to change the base?
perf: wheel #3157
Conversation
I don't know if this is the solution but some users report high ping when they are using the wheels |
I just tried these changes and it doesn't solve the problem of increasing the ping on the server when making a change in the wheel and pressing either "reset" "apply" or "ok" |
Please, upload a video to see how it happens. |
There you can see that it is very few seconds that it is stuck, I am with the current data of otservbr, using a windows vps it was much more noticeable and I changed to a linux with 6 vCPU Cores |
here I am testing I have a nomal ms |
client.2024-12-03.16-34-52-851.online-video-cutter.com.mp4 |
I just recorded showing the performance of the VPS while applying points on the wheel |
I think you are right I'm just using the wheels and start to raise the cores I know I have only 2 cores but I only have the canary and mysql installed and I know that will hurt the performance canary but as a normal test server, now I imagine several users doing the same thing at the same time will raise all the cores so you have 8 or 14 cores will still go up and you will lose server performance would be an objective of the users to knock down the server. bandicam.2024-12-03.18-00-45-378.mp4 |
I pushed new code with some performance updates, could you please test? |
cf77e71
to
ca1a429
Compare
6bed6a0
to
6e62854
Compare
Quality Gate passedIssues Measures |
Description
Fixes performance issues in the wheel ui, also add the disable of the apply button when the changes be applied and some functions calling order.
Behaviour
Actual
Apply button does not disable after changes applied.
Expected
Apply button does disable after changes applied.
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist