Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash on try gem grade upgrade greater than 3 #3151

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

phacUFPE
Copy link
Contributor

Description

Fixes the crash when trying to upgrade gem to a grade greater than 3

Behaviour

Actual

Crashes the server when trying to upgrade gem to a grade greater than 3.

Expected

Only logs the error when trying to upgrade gem to a grade greater than 3.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

  • Try upgrading gem to a grade greater than 3

Test Configuration:

  • Server Version: Latest
  • Client: 13.40
  • Operating System: Windows 11

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@phacUFPE phacUFPE force-pushed the phacUFPE/fix_crash_gem_upgrade branch from 64ef9e4 to 4a4f3e2 Compare November 24, 2024 03:19
@dudantas dudantas merged commit a77f3c3 into main Nov 24, 2024
35 checks passed
@dudantas dudantas deleted the phacUFPE/fix_crash_gem_upgrade branch November 24, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants