Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove duplicate "update impact tracker" for elemental damage #3137

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix: remove duplicate "update impact tracker" for elemental damage #3137

merged 1 commit into from
Nov 20, 2024

Conversation

dudantas
Copy link
Member

@dudantas dudantas commented Nov 20, 2024 •
edited
Loading

It's already send here:

canary/src/game/game.cpp

Line 7375 in 729387b

attackerPlayer->updateImpactTracker(damage.secondary.type, damage.secondary.value);

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dudantas dudantas merged commit 854f60c into main Nov 20, 2024
35 checks passed
@dudantas dudantas deleted the dudantas/fix-duplicate-impact-damage branch November 20, 2024 14:05
Nave-ot pushed a commit to Nave-ot/canary that referenced this pull request Nov 20, 2024
@dudantas @Nave-ot
fix: remove duplicate "update impact tracker" for elemental damage (o…
e7a74e7 
…pentibiabr#3137)

It's already send here:
https://github.com/opentibiabr/canary/blob/729387bc8b8a6171de32d936a6442cb285c9da42/src/game/game.cpp#L7375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phacUFPE phacUFPE phacUFPE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dudantas @phacUFPE