Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lua getNumber overflow with "MoveEvent::EquipItem" function #3136

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

dudantas
Copy link
Member

Fixed overflow with "MoveEvent::EquipItem" and added imbuement shrine to canary temple

@dudantas dudantas merged commit 729387b into main Nov 20, 2024
40 checks passed
@dudantas dudantas deleted the dudantas/fix-lua-overflow branch November 20, 2024 03:31
@Regeton5306
Copy link

After adding this, it makes it impossible to pick things up from the ground. Anything I drop on the ground can no longer be picked up again.

@dudantas
Copy link
Member Author

After adding this, it makes it impossible to pick things up from the ground. Anything I drop on the ground can no longer be picked up again.

Are you sure you tested this correctly? I couldn't reproduce what you said, I tested it and everything is ok. Also, the if I changed only deals with the reward chest/boss corpse, there would be no way to bug other behaviors.

@Regeton5306
Copy link

After adding this, it makes it impossible to pick things up from the ground. Anything I drop on the ground can no longer be picked up again.

Are you sure you tested this correctly? I couldn't reproduce what you said, I tested it and everything is ok. Also, the if I changed only deals with the reward chest/boss corpse, there would be no way to bug other behaviors.

My base is clean, in fact, I downloaded it about a week ago and I have been adding every update they have merged. I just tried this one and I hadn't noticed until I threw the things I had on the ground and tried to pick them up, but it didn't let me. It just said 'sorry, not possible.' Then I remembered that the only thing I had done was add this, so I reverted the changes, recompiled, and it let me pick them up again. I don't understand.

@dudantas
Copy link
Member Author

After adding this, it makes it impossible to pick things up from the ground. Anything I drop on the ground can no longer be picked up again.

Are you sure you tested this correctly? I couldn't reproduce what you said, I tested it and everything is ok. Also, the if I changed only deals with the reward chest/boss corpse, there would be no way to bug other behaviors.

My base is clean, in fact, I downloaded it about a week ago and I have been adding every update they have merged. I just tried this one and I hadn't noticed until I threw the things I had on the ground and tried to pick them up, but it didn't let me. It just said 'sorry, not possible.' Then I remembered that the only thing I had done was add this, so I reverted the changes, recompiled, and it let me pick them up again. I don't understand.

Maybe it was compilation garbage, the change in the source of this pull request is not even relevant, it does not change the behavior of anything, it just improves the log to identify which function is causing the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants