Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wands and rods chain damage #3128

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

phacUFPE
Copy link
Contributor

@phacUFPE phacUFPE commented Nov 17, 2024

Description

This fixes the damage when chain system enabled for wands and rods.

Behaviour

Actual

Wands and rods does same damage not taking account the fromDamage and toDamage.

Expected

Wands and rods does damage taking account the fromDamage and toDamage.

Fixes #2472

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Enable chain system, equip a snakebite rod and it needs to deal less damage then better rods (grand sanguine rod, hailstorm, etc)
  • Enable chain system, equip a grand sanguine rod and it needs to deal more damage then worse rods (snakebite rod, hailstorm, etc)

Test Configuration:

  • Server Version: Latest
  • Client: 13.40
  • Operating System: Windows 11

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@dudantas dudantas merged commit 93448b8 into main Nov 18, 2024
35 checks passed
@dudantas dudantas deleted the phacUFPE/fix_wand_rods_chain branch November 18, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error in damage wand/rods with the chain system
2 participants