Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: blessings calculations #3126

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix: blessings calculations #3126

merged 1 commit into from
Nov 18, 2024

Conversation

murilo09
Copy link
Contributor

@murilo09 murilo09 commented Nov 17, 2024 •
edited
Loading

Description

Wrong blessing calculations

Behaviour

Actual

Lose all skills

Expected

Lose correct percentage

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@htc16
Copy link
Contributor

htc16 commented Nov 17, 2024

I'm already testing it, thank you for that!

@murilo09 murilo09 linked an issue Nov 17, 2024 that may be closed by this pull request
reset skill when player death #3127
Closed
5 tasks
phacUFPE
phacUFPE approved these changes Nov 17, 2024
View reviewed changes
Copy link
Contributor

@phacUFPE phacUFPE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working as expected

@dudantas dudantas merged commit 3bdad99 into main Nov 18, 2024
35 checks passed
@dudantas dudantas deleted the fix-bless-calc branch November 18, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htc16 htc16 htc16 approved these changes

@majestyotbr majestyotbr majestyotbr approved these changes

@phacUFPE phacUFPE phacUFPE approved these changes

@dudantas dudantas dudantas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reset skill when player death
5 participants
@murilo09 @htc16 @dudantas @phacUFPE @majestyotbr