fix: forge history #3124
Merged
fix: forge history #3124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems to me that the problem was even deeper because it doesn't show the history of forges, as soon as I'm on my computer I'll test the pr, thank you for your help. |
|
|
htc16
approved these changes
Nov 17, 2024
htc16
approved these changes
Nov 17, 2024
majestyotbr
approved these changes
Nov 17, 2024
dudantas
force-pushed
the
phacUFPE/fix_forge_history
branch
from
e04c208 to
2e34768
Compare
|
dudantas
approved these changes
Nov 19, 2024
This comment has been minimized.
This comment has been minimized.
|
@AL-L-S You forgot to compile the source code. The log is telling that, you are holding the version that is crashing yet.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the history forge that is crashing the server trying to access an index of a empty vector.
Behaviour
Actual
Open the forge window and the server crash
Expected
Open the forge window and check the history, it should display the history if there is history and none if forge was never used
Fixes #3121
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist