Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: specific meal purchase option for hireling #3105

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

valdzera
Copy link
Contributor

Hireling NPC Feature Update: Specific Meal Selection

This update introduces a new feature for the hireling NPC, allowing players to choose specific meals for 90,000 gold, aligning with the latest global updates. The NPC now prompts players with options for a "specific" or "surprise" meal, guiding them through the selection process. If "specific" is chosen, players are presented with a list of available dishes.

Description

Please include a summary of the change and which issue is fixed. Also, provide relevant motivation and context. List any dependencies required for this change.

Behaviour

Actual

Do this, and that doesn’t happen.

Expected

Do this, and that happens.

Fixes #issuenumber

Type of Change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

Please describe the tests you ran to verify your changes. Provide instructions so we can reproduce them. List any relevant details for your test configuration.

  • Test A
  • Test B

Test A: Specific Food Order Test

  • NPC Configuration: The NPC was initialized with cooking skills, enabling it to accept specific food orders.

  • Steps:

    1. The player initiates a conversation with the NPC and selects the “Food” option.
    2. The NPC responds with options for a surprise meal at 15,000 gold or a specific dish at 90,000 gold.
    3. The player chooses the “specific” option.
    4. The NPC provides a list of available specific dishes.
    5. The player selects a specific dish from the list.
  • Verification:

    • The NPC charges the player 90,000 gold and delivers the selected dish to the player's inbox.

Test B: Surprise Meal Order Test

  • NPC Interaction:

    • The player initiates a conversation and selects the “Food” option.
    • The player chooses the “surprise” option instead of a specific dish.
  • Verification:

    • The NPC charges the player 15,000 gold and delivers a random dish to the player’s inbox.

These tests confirmed that the NPC’s cooking responses, pricing, and item delivery worked as intended, matching the updates from the global system.

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

This update introduces a new feature for the hireling NPC, allowing players to choose specific meals for 90000 gold, aligning with the latest global updates. The NPC now prompts players with options for a "specific" or "surprise" meal, guiding them through the selection process. If "specific" is chosen, players are presented with a list of available dishes.
valdzera and others added 3 commits November 13, 2024 16:53
Players couldn’t be randomly chosen to select skill-boosting foods. this fix reintroduces the chance to choose a skill dish if selected as a surprise.
@dudantas dudantas merged commit 1765018 into opentibiabr:main Nov 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants