Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: combat type out of index in ashes item #3103

Closed

Conversation

FelipePaluco
Copy link
Contributor

@FelipePaluco FelipePaluco commented Nov 12, 2024

Description

Fixes #2874

Behaviour

Actual

Fix combat type out of index error being spammable if monster is above this specific item.

Also, this should be take in consideration. If a item with primaryType field don't have the attribute key "field" with a proper value and damage as sub-attribute, this can cause a errors.

Expected

Not throw errors and spamming on terminal.

Fixes #2874

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Make a monster walk above this item.

Test Configuration:

  • Server Version: Canary Latest
  • Client: 13.40
  • Operating System: N/A

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@helenarubra
Copy link

Nice!

@FelipePaluco FelipePaluco deleted the FelipePaluco/combat-type branch November 12, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[combatTypeToIndex] Combat type 255 is out of range
3 participants