Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move blessing bytes to cpp #3064

Merged
merged 18 commits into from
Nov 13, 2024
Merged

refactor: move blessing bytes to cpp #3064

merged 18 commits into from
Nov 13, 2024

Conversation

murilo09
Copy link
Contributor

@murilo09 murilo09 commented Nov 5, 2024

Description

Moving bytes from modules to cpp.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link
Member

@dudantas dudantas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small improvements that can be made, otherwise, congratulations, great pr.

src/creatures/players/player.cpp Outdated Show resolved Hide resolved
src/server/network/protocol/protocolgame.cpp Outdated Show resolved Hide resolved
src/server/network/protocol/protocolgame.cpp Outdated Show resolved Hide resolved
Copy link

@dudantas dudantas merged commit a72c5d0 into main Nov 13, 2024
41 checks passed
@dudantas dudantas deleted the rework-bless branch November 13, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants