Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto loot reachable corpses only #2473

Merged
merged 4 commits into from
Mar 26, 2024
Merged

fix: auto loot reachable corpses only #2473

merged 4 commits into from
Mar 26, 2024

Conversation

lezinhu0
Copy link
Contributor

@lezinhu0 lezinhu0 commented Mar 19, 2024

Description

Updates the auto loot system so the player need to have a clear path to the corpse in order to loot it.

Behaviour

Actual

Players can auto loot unreachable monsters, like annihilation demons.

Expected

Players shouldn't loot corpses they cannot walk into.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Just created monsters inside a room with windows and a door, killed the monsters through the window and with the door opened.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@sindinn
Copy link

sindinn commented Mar 20, 2024

An interesting fix.

@elsongabriel elsongabriel changed the title FIX: Auto loot reachable corpses only fix: auto loot reachable corpses only Mar 20, 2024
@elsongabriel
Copy link
Contributor

elsongabriel commented Mar 20, 2024

remove package.lock from the pr and enable to run github action in your settings, to clang-format runs.

Mirkaanks

This comment was marked as resolved.

@elsongabriel elsongabriel merged commit 8dec6f9 into opentibiabr:main Mar 26, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants