Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set isBlocking to false for area runes #2468

Merged
merged 2 commits into from
Mar 19, 2024
Merged

fix: set isBlocking to false for area runes #2468

merged 2 commits into from
Mar 19, 2024

Conversation

Aerwix
Copy link
Contributor

@Aerwix Aerwix commented Mar 19, 2024 •
edited by dudantas
Loading

Resolves #2467

AoE Runes:

  • Great Fireball Rune
  • Avalanche Rune
  • Thunderstorm Rune
  • Stone Shower Rune

Bomb Runes

  • Fire Bomb Rune
  • Energy Bomb Rune
  • Poison Bomb Rune

Wall Runes

  • Fire Wall Rune
  • Energy Wall Rune
  • Poison Wall Rune

@Aerwix Aerwix marked this pull request as ready for review March 19, 2024 03:12
@dudantas dudantas changed the title fix: shoot AoE runes over items fix: set isBlocking to false for area runes Mar 19, 2024
@dudantas
Copy link
Member

dudantas commented Mar 19, 2024 •
edited
Loading

image

Please, follow the pull request template, for example, in the issue part it is mentioned for you to add
"Fix #issuenumber" so the issue will already be linked to the pull request, sometimes we forget to fix this before merging.

@dudantas dudantas merged commit 944c74b into opentibiabr:main Mar 19, 2024
24 checks passed
@Aerwix Aerwix deleted the fix-shoot-runes-over-items branch March 19, 2024 18:57
@majestyotbr majestyotbr linked an issue Mar 20, 2024 that may be closed by this pull request
Runes usage in tiles. #2446
Open
5 tasks
@majestyotbr majestyotbr removed a link to an issue Mar 20, 2024
Runes usage in tiles. #2446
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renanzera renanzera renanzera approved these changes

@dudantas dudantas dudantas approved these changes

@elsongabriel elsongabriel elsongabriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Aerwix @dudantas @elsongabriel @renanzera