Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: faceless bane mechanics and quest #2466

Closed

Conversation

CarlosE-Dev
Copy link
Contributor

Description

Boss room mechanic for Faceless Bane used in global.

  • Boss invulnerable until specific sqms are stepped on
  • Boss revives
  • Boss resets if 1 minute passes since activation of the squares
  • Boss summons upon revival
  • Some changes in life, resistance, and reflected damage (based on Tibia Wiki)
  • Room effects

References:
https://www.tibiawiki.com.br/wiki/The_Dream_Courts_Quest
https://www.tibiawiki.com.br/wiki/Faceless_Bane

image

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

You can test just facing the boss.
Boss lever position: 33638, 32562, 13

Test Configuration:

  • Server Version: 3.1.2
  • Client: 13.32
  • Operating System: Windows

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

-- energy effect to make the boss mortal
local function sendEnergyEffect()
-- positions: pipes on room, that should be electrocuted
local pipePositions = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not that it will make a big difference, but if you leave the positions inside the function they will be related every time you call the function, I would leave them outside the function

@elsongabriel elsongabriel changed the title Feature: Faceless Bane - Boss Room Mechanics feat: faceless bane mechanics and quest Mar 19, 2024
…courts/faceless_bane_step_positions.lua

Co-authored-by: Luan Luciano <[email protected]>
@rokamdev
Copy link

Muito bom. Apenas 1 observação que pode ter passado despercebido. [...] Faceless estará invulnerável assim que a luta começar, sendo necessário que um jogador ande por todos os 13 pisos de metal presentes na sala em no máximo 15 segundos. [...] Efetuando os testes, e pisando em 12 sqm's, apos os 15 segundos a contagem nao é resetada. ficando assim, por tempo "indeterminado" aguardando ser pisado no ultimo sqm, para entao deixar o boss vulneravel.
image

@elsongabriel
Copy link
Contributor

PR closing because the author didn't answer the suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants