-
-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: faceless bane mechanics and quest #2466
Closed
CarlosE-Dev
wants to merge
5
commits into
opentibiabr:main
from
CarlosE-Dev:feat/faceless-bane-boss-room
Closed
feat: faceless bane mechanics and quest #2466
CarlosE-Dev
wants to merge
5
commits into
opentibiabr:main
from
CarlosE-Dev:feat/faceless-bane-boss-room
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luanluciano93
suggested changes
Mar 19, 2024
-- energy effect to make the boss mortal | ||
local function sendEnergyEffect() | ||
-- positions: pipes on room, that should be electrocuted | ||
local pipePositions = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not that it will make a big difference, but if you leave the positions inside the function they will be related every time you call the function, I would leave them outside the function
...rvbr-global/scripts/creaturescripts/quests/the_dream_courts/faceless_bane_step_positions.lua
Outdated
Show resolved
Hide resolved
elsongabriel
changed the title
Feature: Faceless Bane - Boss Room Mechanics
feat: faceless bane mechanics and quest
Mar 19, 2024
…courts/faceless_bane_step_positions.lua Co-authored-by: Luan Luciano <[email protected]>
Chapeleiiro
approved these changes
Apr 27, 2024
rokamdev
approved these changes
Apr 27, 2024
PR closing because the author didn't answer the suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Boss room mechanic for Faceless Bane used in global.
References:
https://www.tibiawiki.com.br/wiki/The_Dream_Courts_Quest
https://www.tibiawiki.com.br/wiki/Faceless_Bane
Type of change
How Has This Been Tested
You can test just facing the boss.
Boss lever position: 33638, 32562, 13
Test Configuration:
Checklist