Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect pricing for enchant/recharge with silver tokens #2463

Merged

Conversation

CarlosE-Dev
Copy link
Contributor

Description

The NPC Cledwyn, who performs enchant/recharge of various items in exchange for silver tokens is ALWAYS charging 2 silver tokens for each operation. However, some of them should cost 5 silver tokens.

Behaviour

Actual

If you request a recharge for an Arboreal Ring, for example, you will be charged 2 silver tokens.

Expected

Items like Arboreal Ring, Spiritthorn Ring should cost 5 silver tokens for recharge.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

You can simply take an Arboreal Ring without charge and request an enchant from NPC Cledwyn. He will say that the operation costs 5 silver tokens, but will only charge 2.

Test Configuration:

  • Server Version: Canary 3.1.2
  • Client: 13.32
  • Operating System: Windows

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@dudantas dudantas changed the title Enchant/Recharge with silver tokens has incorrect pricing fix: incorrect pricing for enchant/recharge with silver tokens Mar 19, 2024
@dudantas dudantas merged commit 18ec4a7 into opentibiabr:main Mar 19, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants