-
-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: uptime in protocolstatus #2459
Conversation
There is an uptime error in protocolstatus, as it does not load the time in the cache correctly, causing it to not update the time. I added this variable within uptime, so that, instead of using the cache time, in specific cases it loads the system time, so it is possible to use this in other parts where uptime is a problem, just adding the true inside OTSYS_TIME().
Did you test it correctly? Did you delete the cache from the previous compiler? |
How can we test this? |
I believe this can occur using debian 12, which is my case, I'm not sure of the real cause of this, because the problem is limited to some people from what I could see. |
I'm checking here, and Myaac give me Uptime: 475597h 48m but, where can we check our uptime? |
From what I understand, the wrong return happens because the system for starting the server cannot even have a predefined time, and when it arrives at the moment that leaves the server online, it loads the 0 uptime that is stored in the cache when it starts. I believe that's it. The only change I made was a modification to the source so that the server gets the system time directly without accessing the cache when online. |
|
but the problem is also with otservlist and the server score starts to drop so much! |
This PR is stale because it has been open 45 days with no activity. |
Description
There is an uptime error in protocolstatus, as it does not load the time in the cache correctly, causing it to not update the time.
I added this variable within uptime, so that, instead of using the cache time, in specific cases it loads the system time, so it is possible to use this in other parts where uptime is a problem, just adding the true inside OTSYS_TIME().
This fixes a time overrun, where the server had been online for over 53 years. One other player and I had this problem, I don't know if other people did.
Behaviour
Actual
Do this and that doesn't happens
Expected
Do this and that happens
Fixes #issuenumber
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist