Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: The Lost Brother Quest #2454

Merged
merged 8 commits into from
Apr 26, 2024

Conversation

CarlosE-Dev
Copy link
Contributor

Description

Implementation of the quest "The Lost Brother".
It's a small quest initiated with the NPC Tarun, with one of the rewards being able to negotiate with the NPC. So, this part was also modified so that the negotiation can only be done once this quest is complete.

This quest is also necessary for the start of the "Within the Tides Quest" (access to Marapur).

Tested INGAME in different ways and with different characters, everything seems to work well.

Discord: shion.dev
Reference: https://www.tibiawiki.com.br/wiki/The_Lost_Brother_Quest

image

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

  • Go to NPC Tarun and ask for mission

Test Configuration:

  • Server Version: Canary 3.1.2
  • Client: 13.32
  • Operating System: Windows

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@elsongabriel
Copy link
Contributor

please, allow to github actions run in your fork repository. (lua-format didn't load)

data-otservbr-global/npc/tarun.lua Show resolved Hide resolved
data-otservbr-global/npc/tarun.lua Show resolved Hide resolved
data-otservbr-global/npc/tarun.lua Outdated Show resolved Hide resolved
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale No activity label Apr 19, 2024
@dudantas dudantas merged commit 56793a0 into opentibiabr:main Apr 26, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale No activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants