Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loot pouch as quick loot #2411

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

matheus-bona
Copy link
Contributor

Description

Currently, it is not possible to equip the loot pouch (gold pouch) with it activated in the config.lua, as there is a reversal in logic where it accepts it as a loot pouch.

I compared it with the old code, and indeed, the logic was inverted in a recent commit.

I have already tested this modification, and everything occurs correctly.

Behaviour

Actual

It doesnt allow you to equip loot pouch on quick looting (Manage loot container window).

Expected

It should accept loot pouch as quickloot (when activated on config.lua)

Fixes #2402

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

I built the new change and tested on a character with loot pouch. I also, tested the quicklooting system. Everything worked.

Test Configuration:

  • Server Version: 3.1.2
  • Client: 13.32
  • Operating System: Linux

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@dudantas dudantas merged commit 07bf7be into opentibiabr:main Mar 11, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inverted logic when setting loot pouch as quick loot
2 participants