improve: Outfit(addons) & Mounts database changes

[luanluciano93]

We are moving Outfits(addons) & Mounts from storagevalues into their own respective database tables.
Increased the mount id size from uint8_t to uint16_t as we already reached 200 mounts and we are soon hitting a wall.

Credits: @EvilHero90

[Aerwix]

Will this fix that bug where the GOD is wearing exclusive outfits(GM Outfits) that can't have mount and you select Change Outfit and it crashes the client?

Someone made an issue but I don't get it well.

[omarcopires]

Will this fix that bug where the GOD is wearing exclusive outfits(GM Outfits) that can't have mount and you select Change Outfit and it crashes the client?

Someone made an issue but I don't get it well.

These outfits have been removed as they are discontinued.
The problem occurs because there is no compatibility with the mounts and therefore the client crashes. The solution is to remove administrator clothing.

[odisk777]

Will this fix that bug where the GOD is wearing exclusive outfits(GM Outfits) that can't have mount and you select Change Outfit and it crashes the client?

Someone made an issue but I don't get it well.

it is not possible in any customer that the GOD/GM has a mount. it is not designed for that.

[Aerwix]

Will this fix that bug where the GOD is wearing exclusive outfits(GM Outfits) that can't have mount and you select Change Outfit and it crashes the client?
Someone made an issue but I don't get it well.

it is not possible in any customer that the GOD/GM has a mount. it is not designed for that.

Not sure how works here of if it's possible to add a try catch option to AVOID the debug.

Back in time during the Panfestival you were able to wear GM outfit being player and of course client didn't crash with mount option.
Check minute 14, he wears the GM outfit and mount is removed instantly (this is exactly what we have to do to avoid the debug)
https://youtu.be/uLqSYAffQ-g?feature=shared&t=840

[odisk777]

Will this fix that bug where the GOD is wearing exclusive outfits(GM Outfits) that can't have mount and you select Change Outfit and it crashes the client?
Someone made an issue but I don't get it well.

it is not possible in any customer that the GOD/GM has a mount. it is not designed for that.

Not sure how works here of if it's possible to add a try catch option to AVOID the debug.

Back in time during the Panfestival you were able to wear GM outfit being player and of course client didn't crash with mount option. Check minute 14, he wears the GM outfit and mount is removed instantly (this is exactly what we have to do to avoid the debug) https://youtu.be/uLqSYAffQ-g?feature=shared&t=840

Mmm I see your point, but I think that's only for event occasions, I don't think you give everyone access to GM's outfits.

[dudantas]

We have a problem with this pull request; many sites use this form of storage to fetch mounts and outfits, if I'm not mistaken. Have you checked how this will be affected?

[luanluciano93]

We have a problem with this pull request; many sites use this form of storage to fetch mounts and outfits, if I'm not mistaken. Have you checked how this will be affected?

I looked in the most used AAC:

• https://github.com/slawkens/myaac
• https://github.com/gesior/Gesior2012
• https://github.com/Znote/ZnoteAAC

none of them pull the outfits from the storage table binary

[phacUFPE]

Is this PR ready for testing?

[luanluciano93]

Is this PR ready for testing?

yes

[github-actions]

This PR is stale because it has been open 45 days with no activity.