Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Save players on closing server #2400

Closed
wants to merge 1 commit into from
Closed

* Save players on closing server #2400

wants to merge 1 commit into from

Conversation

jprzimba
Copy link

@jprzimba jprzimba commented Mar 8, 2024

Now server clan be closed and saving players

@dudantas
Copy link
Member

dudantas commented Mar 8, 2024

This doesn't seem right to me. The right thing to do is to shut down.

@dguprado

This comment was marked as spam.

@luanluciano93
Copy link
Contributor

This doesn't seem right to me. The right thing to do is to shut down.

Why doesn't the canary have the /shutdown command? How to shut down the canary without using the close button?

/closeserver shutdown

@jprzimba
Copy link
Author

jprzimba commented Mar 9, 2024

This doesn't seem right to me. The right thing to do is to shut down.

I've tryed shutdown but it cases some issues.
this method works properly

@jprzimba
Copy link
Author

jprzimba commented Mar 9, 2024

This doesn't seem right to me. The right thing to do is to shut down.

your can chance
g_saveManager().scheduleAll();
exit(0);

to shutdown();

Copy link
Member

@dudantas dudantas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't make sense. You released the "x" button and want it to save? It's disabled for a good reason; it automatically closes the console 5 seconds after being pressed, regardless of whether it's still saving or not.

To close the console, the correct way is to use the shutdown command or use "ctrl + c"; the exit button is not recommended to be used, and that's why it's disabled.

@jprzimba jprzimba closed this by deleting the head repository Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants