Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: achievement progress #2238

Merged
merged 5 commits into from
Feb 15, 2024
Merged

fix: achievement progress #2238

merged 5 commits into from
Feb 15, 2024

Conversation

dudantas
Copy link
Member

@dudantas dudantas commented Feb 15, 2024

Complement of pr: #2215

Removed duplicated files from data-canary.

@dudantas dudantas force-pushed the dudantas/fix-achievement-progress branch from 94c077c to 76479c8 Compare February 15, 2024 12:02
@omarcopires
Copy link
Contributor

[2024-15-02 09:26:11.529] [error] Lua Script Error Detected
---------------------------------------
Interface: Scripts Interface
Script ID: E:\Repositorios Mystic\server\data-otservbr-global/scripts\globalevents\game_migrations\move_achievement_to_kv.lua
Error Description: ...s Mystic\server\data/scripts/lib\register_migrations.lua:48: Invalid migration name: move_achievement_to_kv. Migration names must be in the format: <timestamp>_<description>. Example: 20231128213149_add_new_monsters
stack traceback:
        [C]: at 0x7ff700d95bd0
        [C]: in function 'error'
        ...s Mystic\server\data/scripts/lib\register_migrations.lua:48: in function 'register'
        ...\globalevents\game_migrations\move_achievement_to_kv.lua:20: in main chunk
---------------------------------------

[2024-15-02 09:26:11.529] [error] E:\Repositorios Mystic\server\data-otservbr-global/scripts\globalevents\game_migrations\move_achievement_to_kv.lua

@dudantas
Copy link
Member Author

[2024-15-02 09:26:11.529] [error] Lua Script Error Detected
---------------------------------------
Interface: Scripts Interface
Script ID: E:\Repositorios Mystic\server\data-otservbr-global/scripts\globalevents\game_migrations\move_achievement_to_kv.lua
Error Description: ...s Mystic\server\data/scripts/lib\register_migrations.lua:48: Invalid migration name: move_achievement_to_kv. Migration names must be in the format: <timestamp>_<description>. Example: 20231128213149_add_new_monsters
stack traceback:
        [C]: at 0x7ff700d95bd0
        [C]: in function 'error'
        ...s Mystic\server\data/scripts/lib\register_migrations.lua:48: in function 'register'
        ...\globalevents\game_migrations\move_achievement_to_kv.lua:20: in main chunk
---------------------------------------

[2024-15-02 09:26:11.529] [error] E:\Repositorios Mystic\server\data-otservbr-global/scripts\globalevents\game_migrations\move_achievement_to_kv.lua

Fixed

@omarcopires
Copy link
Contributor

omarcopires commented Feb 15, 2024

[2024-15-02 09:26:11.529] [error] Lua Script Error Detected
---------------------------------------
Interface: Scripts Interface
Script ID: E:\Repositorios Mystic\server\data-otservbr-global/scripts\globalevents\game_migrations\move_achievement_to_kv.lua
Error Description: ...s Mystic\server\data/scripts/lib\register_migrations.lua:48: Invalid migration name: move_achievement_to_kv. Migration names must be in the format: <timestamp>_<description>. Example: 20231128213149_add_new_monsters
stack traceback:
        [C]: at 0x7ff700d95bd0
        [C]: in function 'error'
        ...s Mystic\server\data/scripts/lib\register_migrations.lua:48: in function 'register'
        ...\globalevents\game_migrations\move_achievement_to_kv.lua:20: in main chunk
---------------------------------------

[2024-15-02 09:26:11.529] [error] E:\Repositorios Mystic\server\data-otservbr-global/scripts\globalevents\game_migrations\move_achievement_to_kv.lua

Fixed

continua com o mesmo problema, tem que renomear para:

local migration = Migration("20241708000535_move_achievement_to_kv")

@dudantas
Copy link
Member Author

20241708000535

Verdade, mudei.

@omarcopires
Copy link
Contributor

20241708000535

Verdade, mudei.

acho que seria uma boa renomear esses arquivos e tirar o timestamp deles, deixar somente no código.

@dudantas
Copy link
Member Author

20241708000535

Verdade, mudei.

acho que seria uma boa renomear esses arquivos e tirar o timestamp deles, deixar somente no código.

Creio que a ideia seja que o mais recente esteja sempre antes.

@dudantas dudantas added this pull request to the merge queue Feb 15, 2024
Merged via the queue into main with commit 93f362f Feb 15, 2024
27 checks passed
@dudantas dudantas deleted the dudantas/fix-achievement-progress branch February 15, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants