Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: take screenshot #2116

Merged
merged 54 commits into from
Jul 8, 2024
Merged

Conversation

luanluciano93
Copy link
Contributor

@luanluciano93 luanluciano93 commented Jan 16, 2024

Constantes:

  • SCREENSHOT_TYPE_ACHIEVEMENT = 1
  • SCREENSHOT_TYPE_BESTIARYENTRYCOMPLETED = 2
  • SCREENSHOT_TYPE_BESTIARYENTRYUNLOCKED = 3
  • SCREENSHOT_TYPE_BOSSDEFEATED = 4
  • SCREENSHOT_TYPE_DEATHPVE = 5
  • SCREENSHOT_TYPE_DEATHPVP = 6
  • SCREENSHOT_TYPE_LEVELUP = 7
  • SCREENSHOT_TYPE_PLAYERKILLASSIST = 8
  • SCREENSHOT_TYPE_PLAYERKILL = 9
  • SCREENSHOT_TYPE_PLAYERATTACKING = 10
  • SCREENSHOT_TYPE_TREASUREFOUND = 11
  • SCREENSHOT_TYPE_SKILLUP = 12

@luanluciano93 luanluciano93 marked this pull request as draft January 16, 2024 07:01
@dudantas
Copy link
Member

dudantas commented Jan 16, 2024

enum class Screenshot_t: uint8_t {
    None,
    Achievement,
    BestiaryEntryCompleted,
    BestiaryEntryUnlocked,
    BossDefeated,
    DeathPve,
    DeathPvp,
    LevelUp,
    PlayerKillAssist,
    PlayerKill,
    PlayerAttacking,
    TreasureFound,
    SkillUp
};

And here:

registerEnum(L, WEAPON_MISSILE);

	std::string luaNamespace = "ScreenshotType_";
	for (auto value : magic_enum::enum_values<Screenshot_t>()) {
		registerMagicEnumNamespace(L, luaNamespace, value);
	}

@luanluciano93
Copy link
Contributor Author

as situações das screenshots faço em c++ ou lua?

@beats-dh
Copy link
Collaborator

as situações das screenshots faço em c++ ou lua?

C++

@luanluciano93 luanluciano93 marked this pull request as ready for review January 19, 2024 12:26
@luanluciano93 luanluciano93 marked this pull request as draft January 19, 2024 12:26
@majestyotbr
Copy link
Contributor

Do you intend to finish this PR? What do you need?

@luanluciano93
Copy link
Contributor Author

Do you intend to finish this PR? What do you need?

my part is ready, it can be approved, for add-ons just open PR later

@elsongabriel elsongabriel merged commit 9490111 into opentibiabr:main Jul 8, 2024
29 checks passed
@luanluciano93 luanluciano93 deleted the take-screenshot branch July 8, 2024 00:16
pasturryx pushed a commit to pasturryx/canary1 that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants