-
-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: take screenshot #2116
Merged
Merged
feat: take screenshot #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enum class Screenshot_t: uint8_t {
None,
Achievement,
BestiaryEntryCompleted,
BestiaryEntryUnlocked,
BossDefeated,
DeathPve,
DeathPvp,
LevelUp,
PlayerKillAssist,
PlayerKill,
PlayerAttacking,
TreasureFound,
SkillUp
}; And here:
std::string luaNamespace = "ScreenshotType_";
for (auto value : magic_enum::enum_values<Screenshot_t>()) {
registerMagicEnumNamespace(L, luaNamespace, value);
} |
dudantas
reviewed
Jan 16, 2024
Co-authored-by: Eduardo Dantas <[email protected]>
Co-authored-by: Eduardo Dantas <[email protected]>
Co-authored-by: Eduardo Dantas <[email protected]>
Co-authored-by: Eduardo Dantas <[email protected]>
as situações das screenshots faço em c++ ou lua? |
C++ |
…nary into take-screenshot
Do you intend to finish this PR? What do you need? |
my part is ready, it can be approved, for add-ons just open PR later |
elsongabriel
approved these changes
Jul 6, 2024
majestyotbr
approved these changes
Jul 6, 2024
elsongabriel
reviewed
Jul 6, 2024
Chapeleiiro
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constantes: