Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send correct tier data #2092

Closed
wants to merge 1 commit into from
Closed

fix: send correct tier data #2092

wants to merge 1 commit into from

Conversation

un000000
Copy link
Contributor

@un000000 un000000 commented Jan 9, 2024

Behaviour

Actual

In Exaltation Forge's Transfer window: clicking tier 10 item crashes client; exalted core costs differ from tibia.fandom.com data.

Expected

In Exaltation Forge's Transfer window: clicking tier 10 item shows costs; exalted core costs are the same as on tibia.fandom.com.

Fixes #2090

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Tested transfers on all tiers of class 2 and 3.
Tested 10->9 and 2->1 for class 4.

Test Configuration:

  • Server Version: up to 6ae7aec
  • Client: 13.21.13839
  • Operating System: Win10

@enzerah
Copy link
Contributor

enzerah commented Jan 9, 2024

you sure you've tested this change ?

Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@dudantas
Copy link
Member

The solution here is to start the iteration at 1 and not 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client crash on selecting Tier 10 item in Exaltation forge Transfer window
3 participants