-
-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new global event OnSave #2025
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Certifique-se de realizar testes de compilação e corrigir quaisquer problemas antes de criar um pull request. Isso está documentado no template do pull request, onde você deve listar os passos para testar a sua alteração e marcar as caixas indicando que realizou esses testes. Parece que essas etapas não foram seguidas aqui, uma vez que as compilações estão quebradas.
canary/.github/PULL_REQUEST_TEMPLATE.md
Line 30 in 5c87e81
- [ ] Test A |
canary/.github/PULL_REQUEST_TEMPLATE.md
Line 42 in 5c87e81
- [ ] I have performed a self-review of my own code |
canary/.github/PULL_REQUEST_TEMPLATE.md
Line 43 in 5c87e81
- [ ] I checked the PR checks reports |
canary/.github/PULL_REQUEST_TEMPLATE.md
Line 47 in 5c87e81
- [ ] I have added tests that prove my fix is effective or that my feature works |
Além disso, seria benéfico adicionar um script de teste para que outros desenvolvedores possam facilmente testar suas mudanças, caso desejem fazê-lo. Isso tornará o processo de revisão e integração mais eficiente.
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
This PR is stale because it has been open 45 days with no activity. |
Quality Gate failedFailed conditions D Maintainability Rating on New Code (required ≥ A) See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
@dudantas Is something missing here? |
This PR is stale because it has been open 45 days with no activity. |
Is this ready for tests? |
yes |
Do you have a example to test? |
just save the game, the event itself is to map conditions for saving the game |
Description
Expected
Why don't we call in saveGameState? In situations like shutdown, things happen beforehand (players being sent off, etc.), so we call individually.
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist
Credits: ramon-bernardo