Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new global event OnSave #2025

Merged
merged 27 commits into from
Jul 11, 2024
Merged

Conversation

luanluciano93
Copy link
Contributor

@luanluciano93 luanluciano93 commented Dec 14, 2023

Description

  • Add new global event: On Save.

Expected

Why don't we call in saveGameState? In situations like shutdown, things happen beforehand (players being sent off, etc.), so we call individually.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • the GAME_STATE_SHUTDOWN and GAME_STATE_CLOSED methods were executed without prejudice.

Test Configuration:

  • Server Version: Canary Main
  • Client: 13.21
  • Operating System: Windows

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Credits: ramon-bernardo

Copy link
Member

@dudantas dudantas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Certifique-se de realizar testes de compilação e corrigir quaisquer problemas antes de criar um pull request. Isso está documentado no template do pull request, onde você deve listar os passos para testar a sua alteração e marcar as caixas indicando que realizou esses testes. Parece que essas etapas não foram seguidas aqui, uma vez que as compilações estão quebradas.


- [ ] I have performed a self-review of my own code

- [ ] I checked the PR checks reports

- [ ] I have added tests that prove my fix is effective or that my feature works

Além disso, seria benéfico adicionar um script de teste para que outros desenvolvedores possam facilmente testar suas mudanças, caso desejem fazê-lo. Isso tornará o processo de revisão e integração mais eficiente.

Copy link

Copy link
Contributor

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale No activity label Jan 14, 2024
@github-actions github-actions bot removed the Stale No activity label Jan 15, 2024
Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@luanluciano93
Copy link
Contributor Author

@dudantas Is something missing here?

Copy link
Contributor

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale No activity label Apr 19, 2024
@github-actions github-actions bot removed the Stale No activity label Apr 20, 2024
@majestyotbr
Copy link
Contributor

Is this ready for tests?

@luanluciano93
Copy link
Contributor Author

Is this ready for tests?

yes

@majestyotbr
Copy link
Contributor

Do you have a example to test?

@luanluciano93
Copy link
Contributor Author

Do you have a example to test?

just save the game, the event itself is to map conditions for saving the game

@dudantas dudantas merged commit 3f12a85 into opentibiabr:main Jul 11, 2024
25 of 29 checks passed
@luanluciano93 luanluciano93 deleted the save-event branch July 11, 2024 22:53
pasturryx pushed a commit to pasturryx/canary1 that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants