New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cobra vizier chain attack #2012

Merged

luan merged 2 commits into main from luan/cobra-attacks

Dec 10, 2023

Merged

feat: cobra vizier chain attack #2012

Update cobra_assassin.lua

GitHub Actions / shellcheck succeeded Dec 10, 2023 in 0s

reviewdog [shellcheck] report

reported by reviewdog 🐶

Findings (0)

Filtered Findings (8)

recompile.sh|65 col 30| To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify).
start_gdb.sh|18 col 6| Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
docker/config.sh|13 col 11| Use grep -q instead of comparing output with [ -n .. ].
tests/build_and_run.sh|7 col 1| Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
tests/build_and_run.sh|8 col 38| Quote this to prevent word splitting.
tests/build_and_run.sh|8 col 38| Use $(...) notation instead of legacy backticks ....
tests/build_and_run.sh|10 col 1| Use a ( subshell ) to avoid having to cd back.
tests/build_and_run.sh|11 col 1| Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

View more details on GitHub Actions