-
-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement tournament market custom #1901
feat: implement tournament market custom #1901
Conversation
a31b7ec
to
24a6222
Compare
7a89496
to
8c12f8c
Compare
7d2ae8f
to
f85ec3c
Compare
211df61
to
916c186
Compare
cda782b
to
18c6152
Compare
@elsongabriel eu acho que isso deveria ser mais opcional. Não registrar o evento no item a não ser que a feature esteja ativada, eu não lembro de quando as tournament coins foram adicionadas de novo, mas como que isso funciona sem ter no client? |
é usado o npc Jeronimo, que ele que faz as "transações" do tournament. seria só uma moeda extra mesmo. |
Quality Gate failedFailed conditions C Maintainability Rating on New Code (required ≥ A) See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
This PR is stale because it has been open 45 days with no activity. |
…tournament coins (item used as tournament coins: gold of bar).
…store, but isn't purchasable, ONLY IN NPC)
913b190
to
248cdb1
Compare
248cdb1
to
be4f911
Compare
i'm closing this pull request due to inactivity. Feel free to reopen when you decide to finish. |
Description
This is a improvement, that need a little observation in some cases, as:
Behaviour
Actual
Bar of gold is a monster lootable item, when you click on it, it doesn't do anything.
Expected
Bar of gold now will be called Tournament Coin, when you click on it, you'll add to your accounts table
tournament_coins
the tournament coins quantity you have with you.Type of change
How Has This Been Tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist