Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: rework in unscripted weapons and moveevents #1494

Merged
merged 13 commits into from
Feb 29, 2024

Conversation

dudantas
Copy link
Member

@dudantas dudantas commented Aug 23, 2023

Add moveevent and weapons unscripted to load in items.xml

TODO:

  • Fix reload items crash
  • Implement load weapons logic
  • Convert all items to the new model.
  • Implement chain logic

Conversor link: https://github.com/dudantas/weapon-moveevents-conversor

Add moveevent and weapons unscripted to load in items.xml

TODO:
- [ ] Fix reload items crash
- [ ] Implement load weapons logic
@dudantas dudantas force-pushed the improve-rework-unscripted-weapon-and-moveevent branch from 2da40ca to dce63dc Compare August 23, 2023 16:46
@dudantas dudantas force-pushed the improve-rework-unscripted-weapon-and-moveevent branch from f6ab67e to 38d8135 Compare September 21, 2023 20:28
…ripted-weapon-and-moveevent

* upstream/main: (21 commits)
  improve: revision of codes in data/ (#1374)
  fix: questlog message (#1648)
  improve: ensure players are removed from zones on death (#1650)
  improve: zstream static (#1644)
  feat: adding training shield and exercise shields (#1607)
  feat: benchmark tools (#1649)
  improve: optimize house/kv saves (#1634)
  fix: wong prey race ids and trashholder items (#1643)
  fix: move store items only to house tile (#1642)
  fix: attr condition enums (subid foods and others) (#1641)
  docs: add TNT Cloud support (#1639)
  fix: house transfer owner only in startup (#1621)
  fix: transfer house item (#1633)
  fix: some getUserdataShared and transfer house (sell) (#1632)
  fix: ammotype sanguine crossbow (#1624)
  feat: update talkactions add_addons and add_mounts (#1612)
  feature: imbuements get slot items (#1628)
  fix: reward container add charges to the items on boss death (#1629)
  improve: convert NetworkMessage and Combat to shared_ptr (#1627)
  feat: config.lua option for enable/disable mount in protection zone (#1599)
  ...
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 31 Code Smells

0.0% 0.0% Coverage
5.4% 5.4% Duplication

@github-actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale No activity label Oct 31, 2023
@dudantas dudantas marked this pull request as draft November 13, 2023 18:19
@github-actions github-actions bot removed the Stale No activity label Nov 14, 2023
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale No activity label Dec 14, 2023
@dudantas dudantas marked this pull request as ready for review February 25, 2024 20:43
@github-actions github-actions bot removed the Stale No activity label Feb 26, 2024
@dudantas dudantas force-pushed the improve-rework-unscripted-weapon-and-moveevent branch from f33ef86 to f0d5c4e Compare February 28, 2024 22:23
@dudantas dudantas merged commit 355fca6 into main Feb 29, 2024
44 checks passed
@dudantas dudantas deleted the improve-rework-unscripted-weapon-and-moveevent branch February 29, 2024 12:09
dudantas added a commit that referenced this pull request Mar 18, 2024
Fix related from the pr: #1494

Resolves #2464
Resolves #2383
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants