Fix build to not use asan on relase mode (#308)

- Not use ASAN for release build
- Remove cmake settings(replaced with presets)
- Adjust GHA triggers

Signed-off-by: Renato Foot <[email protected]>

.github/ISSUE_TEMPLATE/bug.yaml

@@ -1,6 +1,5 @@
 name: Report a problem/bug
 description: Any issues that you have found while using the server
-title: "[Bug]: "
 labels: ["Status: Pending Test", "Type: Bug"]
 body:
   - type: markdown
@@ -21,7 +20,6 @@ body:
     validations:
       required: true
 
-
   - type: checkboxes
     id: area
     attributes:
@@ -39,38 +37,12 @@ body:
     id: what-happened
     attributes:
       label: What happened?
-      description: Describe the problem/bug!
+      description: Describe your problem/bug and add screenshots, logs or anything that can help verifying the bug
       placeholder: Tell us what you see!
       value: "A bug happened!"
     validations:
       required: true
 
-  - type: textarea
-    id: steps-reproduce
-    attributes:
-      label: How to Reproduce?
-      description: Steps to reproduce the problem, position on the map, etc
-      placeholder: Tell us exactly how to reproduce and the position on the map!
-      value: |
-        1 - go to position 134,543,7
-        2 - Try to open the door
-        3 - Door doesn't open!
-    validations:
-      required: true
-
-  - type: textarea
-    id: logs
-    attributes:
-      label: Relevant log output
-      description: Please copy and paste any relevant log output. This will be automatically formatted into code, so no need for backtick.
-      render: shell
-
-  - type: textarea
-    id: attach
-    attributes:
-      label: Attach any relevant file
-      description: Attach screenshots, full logs, etc ... that helps verifying the bug
-
   - type: dropdown
     id: os
     attributes:

.github/ISSUE_TEMPLATE/content.yaml

@@ -1,26 +1,12 @@
 name: Report a missing content
 description: Any thing that is missing
-title: "[Content]: "
 labels: ["Status: Pending Test", "Type: Missing Content"]
 body:
   - type: markdown
     attributes:
       value: |
         Thanks for taking the time to fill out this issue!
 
-  - type: dropdown
-    id: priority
-    attributes:
-      label: Priority
-      description: How critical is this?
-      options:
-        - Low
-        - Medium
-        - High
-        - Critical
-    validations:
-      required: true
-
   - type: checkboxes
     id: area
     attributes:
@@ -38,23 +24,10 @@ body:
     id: missing-content
     attributes:
       label: What is missing?
-      description: Map, sprite, script, quest, teleport, monster, etc
+      description: Map, sprite, script, quest, teleport, monster, etc. Attach screenshots, logs, etc, anything that can helps us
     validations:
       required: true
 
-  - type: textarea
-    id: logs
-    attributes:
-      label: Relevant log output
-      description: Please copy and paste any relevant log output. This will be automatically formatted into code, so no need for backtick.
-      render: shell
-
-  - type: textarea
-    id: attach
-    attributes:
-      label: Attach any relevant file
-      description: Attach screenshots, logs, etc, anything that can helps us
-
   - type: checkboxes
     id: terms
     attributes:

.github/ISSUE_TEMPLATE/enhancement.yaml

@@ -1,26 +1,12 @@
 name: Report a enhancement
 description: Any thing that is missing
-title: "[Enhancement]: "
 labels: ["Status: Pending Test", "Type: Enhancement"]
 body:
   - type: markdown
     attributes:
       value: |
         Thanks for taking the time to fill out this issue!
 
-  - type: dropdown
-    id: priority
-    attributes:
-      label: Priority
-      description: How critical is this?
-      options:
-        - Low
-        - Medium
-        - High
-        - Critical
-    validations:
-      required: true
-
   - type: checkboxes
     id: area
     attributes:
@@ -38,16 +24,10 @@ body:
     id: enhancement
     attributes:
       label: Describe the enhancement
-      description: What should be improved
+      description: What should be improved? Attach screenshots, logs, etc, anything that can helps us
     validations:
       required: true
 
-  - type: textarea
-    id: attach
-    attributes:
-      label: Attach any relevant file
-      description: Attach screenshots, logs, etc, anything that can helps us
-
   - type: checkboxes
     id: terms
     attributes:

.github/workflows/analysis-codacy.yml

@@ -6,9 +6,6 @@ on:
   push:
     branches:
       - main
-      - dev
-      - devel
-      - develop
 
 jobs:
   codacy:

.github/workflows/analysis-reviewdog.yml

@@ -1,6 +1,9 @@
 ---
 name: Analysis - Review Dog
-on: [pull_request]
+
+on:
+  pull_request:
+
 jobs:
 
   cppcheck:

.github/workflows/analysis-sonarcloud.yml

@@ -7,9 +7,6 @@ on:
   push:
     branches:
       - main
-      - dev
-      - devel
-      - develop
 
 env:
   VCPKG_BUILD_TYPE: release

.github/workflows/build-docker.yml

@@ -2,13 +2,11 @@
 name: Build - Docker
 
 on:
+  workflow_dispatch:
   pull_request:
   push:
     branches:
       - main
-      - dev
-      - devel
-      - develop
 
 env:
   VCPKG_BUILD_TYPE: release

.github/workflows/build-ubuntu.yml

@@ -4,6 +4,9 @@ name: Build - Ubuntu
 on:
   workflow_dispatch:
   pull_request:
+  push:
+    branches:
+      - main
 
 env:
   VCPKG_BUILD_TYPE: release

.github/workflows/build-windows.yml

@@ -4,6 +4,9 @@ name: Build - Windows
 on:
   workflow_dispatch:
   pull_request:
+  push:
+    branches:
+      - main
 
 env:
   VCPKG_BUILD_TYPE: release

CMakePresets.json

@@ -66,7 +66,9 @@
       "displayName": "Windows - Debug Build",
       "description": "Build Debug Mode",
       "cacheVariables": {
-        "CMAKE_BUILD_TYPE": "Debug"
+        "CMAKE_BUILD_TYPE": "Debug",
+        "DEBUG_LOG": "ON",
+        "ASAN_ENABLED": "ON"
       },
       "architecture": {
         "value": "x64",
@@ -88,7 +90,9 @@
       "displayName": "Linux - Debug Build",
       "description": "Build Debug Mode",
       "cacheVariables": {
-        "CMAKE_BUILD_TYPE": "Debug"
+        "CMAKE_BUILD_TYPE": "Debug",
+        "DEBUG_LOG": "ON",
+        "ASAN_ENABLED": "ON"
       }
     }
   ],

src/CMakeLists.txt

@@ -25,7 +25,7 @@ set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 # *****************************************************************************
 option(OPTIONS_ENABLE_OPENMP "Enable Open Multi-Processing support." ON)
 option(DEBUG_LOG "Enable Debug Log" OFF)
-option(ASAN_ENABLED "Build this target with AddressSanitizer" ON)
+option(ASAN_ENABLED "Build this target with AddressSanitizer" OFF)
 
 
 # *****************************************************************************